Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update More block description #11587

Merged
merged 3 commits into from
Nov 19, 2018
Merged

Update More block description #11587

merged 3 commits into from
Nov 19, 2018

Conversation

Soean
Copy link
Member

@Soean Soean commented Nov 7, 2018 •
edited
Loading

Description

Updates the description of the More block.
Fixes: #11458

Old:
Want to show only an excerpt of this post on your home page? Use this block to define where you want the separation.
New:
Mark the excerpt of this content. Content before this block will be shown in the excerpt on your archives page.

@Soean Soean added [Type] Copy Issues or PRs that need copy editing assistance Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Nov 7, 2018
@Soean Soean requested a review from alexislloyd November 7, 2018 14:39
@ocean90 ocean90 added this to the 4.3 milestone Nov 7, 2018
@youknowriad youknowriad requested a review from a team November 8, 2018 07:50
@gziolo
Copy link
Member

gziolo commented Nov 8, 2018

It changes more than home page to homepage. @alexislloyd what's your take on the proposed change? It looks like you iterated on it a bit earlier, so I would expect this PR to be scoped to only fix the way home page is used.

@swissspidy
Copy link
Member

Only fixing homepage everywhere in a more scoped fashion makes sense.

We can then improve the text in a separate PR. Could we then get rid of the "post" bit of the description as well please? Otherwise it's not accurate for other post types. I would replace it with "content".

tofumatt
tofumatt requested changes Nov 8, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like block descriptions that lead with questions. We use an entire sentence to ask the user if this is the block they want to be using before telling them what it does; the question is an indirect way of asking them and I don't think it's very instructive 😄

packages/block-library/src/more/index.js Outdated Show resolved Hide resolved
@gziolo gziolo removed this from the 4.3 milestone Nov 9, 2018
@gziolo gziolo mentioned this pull request Nov 9, 2018
Merged
@gziolo
Copy link
Member

gziolo commented Nov 9, 2018

I updated home page with homepage with #11661 to land it in 4.3 and resolve the original issue. Feel free to continue discussion on the improvements to this description without the pressure of time :)

tofumatt
tofumatt approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I say :shipit:

@tofumatt tofumatt added this to the 4.5 milestone Nov 16, 2018
@youknowriad youknowriad merged commit 763bb6b into master Nov 19, 2018
@youknowriad youknowriad deleted the update/more-description branch November 19, 2018 08:51
@afercia afercia mentioned this pull request Dec 28, 2018
Closed
6 tasks
This was referenced Jan 25, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@alexislloyd alexislloyd Awaiting requested review from alexislloyd

Assignees
No one assigned
Labels
Needs Copy Review Needs review of user-facing copy (language, phrasing) [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
6 participants
@Soean @gziolo @swissspidy @tofumatt @youknowriad @ocean90